[code-infra] Restructured tsconfig files #666

brijeshb42 · 2025-09-08T06:11:51Z

All apps/packages now extend a common tsconfig.base.json and only add project specific changes in their own configs.

mui-bot · 2025-09-08T06:13:06Z

Bundle size report

Bundle	Parsed size	Gzip size
@base-ui-components/react	0B^(0.00%)	0B^(0.00%)
@mui/x-charts-pro	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

Copilot

Pull Request Overview

This PR restructures the TypeScript configuration files to follow a hierarchical approach. A new base configuration file tsconfig.options.json is introduced that contains common TypeScript compiler options, which is then extended by other configuration files to avoid duplication.

Created a new base configuration file (tsconfig.options.json) with common TypeScript compiler options
Replaced duplicated configurations across packages and apps with extends patterns
Removed the redundant tsconfig.build.json file from the code-infra package

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tsconfig.options.json	New base configuration file with common TypeScript compiler options
tsconfig.js.json	New configuration extending base options for JavaScript-enabled projects
tsconfig.node.json	Simplified to extend tsconfig.js.json and added babel.config.* to includes
packages/docs-infra/tsconfig.json	Updated to extend tsconfig.options.json and removed redundant options
packages/code-infra/tsconfig.json	Simplified to extend tsconfig.js.json and updated includes
packages/code-infra/tsconfig.build.json	Removed as mentioned in PR description
packages/code-infra/src/cli/typescript.mjs	Added --declarationMap false flag to TypeScript command
packages/bundle-size-checker/tsconfig.json	Simplified to extend tsconfig.js.json
packages/babel-plugin-resolve-imports/tsconfig.json	Simplified to extend tsconfig.js.json
packages/babel-plugin-minify-errors/tsconfig.json	Simplified to extend tsconfig.js.json with updated includes
package.json	Added @types/babel__core dependency
apps/code-infra-dashboard/tsconfig.json	Simplified to extend tsconfig.options.json

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

brijeshb42 · 2025-09-22T13:10:23Z

@Janpot Can I get a review on this ?

Janpot · 2025-09-23T09:32:48Z

When it comes to modularizing tsconfig, I'm not 100% convinced a deep hierarchy is the best solution. See this comment as a reason for allowing arrays in extends. The idea being that you create multiple base configs, each describing an aspect of the environment which you then can freely compose in your app/package configurations. I don't know how that should look exactly, but I'm thinking like e.g. our build tool can export its tsconfig that sets module resolution rules. Maybe we can make a config for when the target is node, and one for when it is browsers. Such that e.g. our node tools extend from ['tsconfig.node.json'] as they're not compiled, but docs-infra from ['tsconfig.browser.json', 'tsconfig.build.json']. In essence aiming at avoiding extending a tsconfig that itselfs also extends.
See also https://github.com/tsconfig/bases

Copilot

Pull Request Overview

Copilot reviewed 31 out of 34 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (2)

packages/code-infra/package.json:55

The test:copy script references bin/code-infra.mjs which no longer exists after moving the entry point to src/code-infra.mjs. This should be updated to node src/code-infra.mjs to match the new bin path.

    "test:copy": "rm -rf build && node bin/code-infra.mjs copy-files --glob \"src/cli/*.mjs\" --glob \"src/eslint/**/*.mjs:esm\""

packages/code-infra/package.json:140

The files array includes "bin" directory which no longer exists after moving the CLI entry point to src/code-infra.mjs. This entry should be removed since the bin file is now in the src directory which is already included in the files array.

    "bin",

Copilot · 2025-10-30T12:38:30Z

packages/bundle-size-checker/tsconfig.build.json

-  "include": ["src/**/*"],
-  // removing "cli" since its going to run directly and not really imported anywhere
-  "exclude": ["**/*.spec.*", "**/*.test.*", "**/setupVitest.ts"]
+  "exclude": ["**/*.spec.*", "**/*.test.*"]


The comment explaining that CLI files are excluded because they run directly was removed, but the actual exclusion logic changed. The old config excluded setupVitest.ts explicitly; the new one only excludes test files. This could lead to setupVitest.ts being included in the build output unintentionally.

Suggested change

"exclude": ["**/*.spec.*", "**/*.test.*"]

"exclude": ["**/*.spec.*", "**/*.test.*", "setupVitest.ts"]

Janpot · 2025-10-31T11:38:48Z

packages/bundle-size-checker/package.json

+    "build",
+    "src",
+    "README.md",
+    "!**/*.tsbuildinfo"


Oh wow, didn't know this supported negative patterns

Janpot · 2025-10-31T11:40:25Z

packages/docs-infra/tsconfig.json

@@ -1,11 +1,6 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": ["../../tsconfig.base.json", "../../tsconfig.node.json"],


🤔 Since we're bundling the code in docs-infra I'd expected it to have a different moduleResiolution (bundler) than what we'd use in untranspiled code for node (node16)

The only difference between bundler and node16 is that bundler doesn't require extensions for relative imports.
I've updated tsconfig.node.json to have moduleResolution of bundler itself.

The only difference between bundler and node16 is that bundler doesn't require extensions for relative imports.

It also resolves index.js files and probably a few other intricacies. There may also be other options that have to differ between transpiled and untranspiled code. e.g. lib, or target

I've updated tsconfig.node.json to have moduleResolution of bundler itself.

Bundler doesn't correctly reflect untranspiled code. If code is meant to run in node.js untranspiled than it needs to have the node16 moduleResolution flag set for it. This prevents us from writing code that wouldn't run. The Bundler option allows us to be ore lenient since the bundler fixes up the resolution for us.

All apps/packages now extend a common tsconfig.options.json and only add project specific changes in their own configs. Removed tsconfig.build.json in code-infra since there is no build step tehre.

and related fixes

brijeshb42 requested review from a team and Copilot September 8, 2025 06:11

brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Sep 8, 2025

oliviertassinari temporarily deployed to typescript-restructure - mui-tools-public PR #666 September 8, 2025 06:12 — with Render Destroyed

This comment was marked as outdated.

Sign in to view

brijeshb42 force-pushed the typescript-restructure branch from f475fa8 to 2a3e603 Compare September 8, 2025 06:14

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 September 8, 2025 06:14 — with Render View deployment

brijeshb42 force-pushed the typescript-restructure branch from 2a3e603 to 535df9c Compare September 8, 2025 10:37

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 September 8, 2025 10:37 — with Render View deployment

brijeshb42 force-pushed the typescript-restructure branch from 535df9c to 0787bb8 Compare September 9, 2025 16:23

oliviertassinari temporarily deployed to typescript-restructure - mui-tools-public PR #666 September 9, 2025 16:23 — with Render Destroyed

brijeshb42 force-pushed the typescript-restructure branch from 0787bb8 to 8040b59 Compare September 9, 2025 16:26

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 September 9, 2025 16:26 — with Render View deployment

brijeshb42 requested a review from Janpot September 9, 2025 16:36

brijeshb42 force-pushed the typescript-restructure branch from 8040b59 to eda5add Compare September 9, 2025 16:37

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 September 9, 2025 16:45 — with Render View deployment

brijeshb42 requested a review from Copilot September 9, 2025 16:48

Copilot AI reviewed Sep 9, 2025

View reviewed changes

oliviertassinari temporarily deployed to typescript-restructure - mui-tools-public PR #666 September 12, 2025 18:56 — with Render Destroyed

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 15, 2025

brijeshb42 force-pushed the typescript-restructure branch from eda5add to 8c940ce Compare September 22, 2025 13:09

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 22, 2025

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 September 22, 2025 13:09 — with Render View deployment

oliviertassinari temporarily deployed to typescript-restructure - mui-tools-public PR #666 September 26, 2025 12:24 — with Render Destroyed

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 30, 2025

brijeshb42 force-pushed the typescript-restructure branch from 8c940ce to a783068 Compare October 3, 2025 05:42

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 3, 2025

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 October 30, 2025 12:09 — with Render View deployment

brijeshb42 force-pushed the typescript-restructure branch from 253d6c2 to d0ec110 Compare October 30, 2025 12:34

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 October 30, 2025 12:34 — with Render View deployment

brijeshb42 requested a review from Copilot October 30, 2025 12:35

Copilot AI reviewed Oct 30, 2025

View reviewed changes

brijeshb42 force-pushed the typescript-restructure branch from d0ec110 to ecf2904 Compare October 30, 2025 12:42

oliviertassinari temporarily deployed to typescript-restructure - mui-tools-public PR #666 October 30, 2025 12:42 — with Render Destroyed

brijeshb42 force-pushed the typescript-restructure branch from ecf2904 to 6872542 Compare October 30, 2025 12:44

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 October 30, 2025 12:44 — with Render View deployment

brijeshb42 force-pushed the typescript-restructure branch from 6872542 to 3f84c2f Compare October 30, 2025 13:01

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 October 30, 2025 13:01 — with Render View deployment

brijeshb42 requested a review from Janpot October 31, 2025 10:18

Janpot reviewed Oct 31, 2025

View reviewed changes

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 2, 2025

brijeshb42 requested a review from Janpot November 3, 2025 07:04

brijeshb42 force-pushed the typescript-restructure branch from 3f84c2f to fec204a Compare November 3, 2025 07:06

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 November 3, 2025 07:06 — with Render View deployment

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 3, 2025

brijeshb42 force-pushed the typescript-restructure branch from fec204a to 3db5eed Compare November 3, 2025 07:25

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 November 3, 2025 07:25 — with Render View deployment

brijeshb42 added 7 commits November 3, 2025 16:20

[infra] Restructured tsconfig files

fdb4579

All apps/packages now extend a common tsconfig.options.json and only add project specific changes in their own configs. Removed tsconfig.build.json in code-infra since there is no build step tehre.

Compose tsconfigs

4129561

dedupe

df259aa

Refactor code-infra tsconfig

942d287

refactor bundle-size-checker types

bd82310

fix ci issues

7d7d40b

Update code-infra tsconfig to be node16

6e886c1

and related fixes

brijeshb42 force-pushed the typescript-restructure branch from fbaae35 to 6e886c1 Compare November 3, 2025 10:52

oliviertassinari deployed to typescript-restructure - mui-tools-public PR #666 November 3, 2025 10:52 — with Render View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[code-infra] Restructured tsconfig files #666

[code-infra] Restructured tsconfig files #666

Uh oh!

brijeshb42 commented Sep 8, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

mui-bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

brijeshb42 commented Sep 22, 2025

Uh oh!

Janpot commented Sep 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 30, 2025

Uh oh!

Janpot Oct 31, 2025

Uh oh!

Janpot Oct 31, 2025

Uh oh!

brijeshb42 Nov 3, 2025

Uh oh!

Janpot Nov 3, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	"exclude": ["*/.spec.", "/.test.*"]
	"exclude": ["*/.spec.", "/.test.*", "setupVitest.ts"]

[code-infra] Restructured tsconfig files #666

Are you sure you want to change the base?

[code-infra] Restructured tsconfig files #666

Uh oh!

Conversation

brijeshb42 commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

mui-bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

brijeshb42 commented Sep 22, 2025

Uh oh!

Janpot commented Sep 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Janpot Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Janpot Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Janpot Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brijeshb42 commented Sep 8, 2025 •

edited

Loading

mui-bot commented Sep 8, 2025 •

edited

Loading

Janpot Nov 3, 2025 •

edited

Loading